Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG CSS Error (CSS-030) being reported in 5.0.0-beta-3 but not earlier versions. #1450

Closed
wareid opened this issue Dec 7, 2022 · 2 comments · Fixed by #1461
Closed

SVG CSS Error (CSS-030) being reported in 5.0.0-beta-3 but not earlier versions. #1450

wareid opened this issue Dec 7, 2022 · 2 comments · Fixed by #1461
Assignees
@rdeltour
Labels
status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Milestone
v5.0.0-rc

Comments

@wareid
Copy link

wareid commented Dec 7, 2022

When testing the file mol-timing-synchronization_svg.epub against EPUBCheck versions for EPUB 3.2 and EPUB 3.3, we are getting different results.

EPUBCheck (v.4.2.6) for EPUB 3.2 validates.

EPUBCheck (v.5.0.0-alpha-1) also validates.

EPUBCheck (v.5.0.0-beta-3) for EPUB 3.3 returns:
ERROR(CSS-030): /GitHub/epub-tests/tests/mol-timing-synchronization_svg.epub/EPUB/mobydick.svg(55,7): The package document declares media overlays styling class names but no CSS was found in the content document.

This error seems to come back regardless of how CSS is referenced in the SVG file. I tested it against:

  • CSS directly added within a <style> element
  • CSS file referenced via @import in the <style> element
  • CSS file linked via the <link> element
@rdeltour
Copy link
Member

rdeltour commented Dec 7, 2022

Ah, I guess this check wasn’t properly tested with SVG content docs. Good catch! 👍

@rdeltour rdeltour self-assigned this Dec 7, 2022
@rdeltour rdeltour added status: accepted Ready to be further processed type: false-positive This issue is about valid content being incorrectly rejected labels Dec 7, 2022
@rdeltour rdeltour added this to the v5.0.0 milestone Dec 7, 2022
@rdeltour
Copy link
Member

rdeltour commented Dec 8, 2022

ref: #1402 where CSS-030 was introduced

@rdeltour rdeltour modified the milestones: v5.0.0, v5.0.0-rc Dec 8, 2022
@rdeltour rdeltour mentioned this issue Dec 13, 2022
Merged
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: accepted Ready to be further processed labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Milestone
v5.0.0-rc
Development

Successfully merging a pull request may close this issue.

feat: check stylesheets declared in SVG w3c/epubcheck
2 participants
@rdeltour @wareid