Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edupub (non-h1..h6) heading not recognized as section heading #1483

Closed
kriro opened this issue Feb 2, 2023 · 2 comments · Fixed by #1502
Closed

edupub (non-h1..h6) heading not recognized as section heading #1483

kriro opened this issue Feb 2, 2023 · 2 comments · Fixed by #1502
Assignees
Labels
priority: medium To be processed and published in one of the upcoming releases spec: EDUPUB Impacting the support of the EDUPUB specification status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Milestone

Comments

@kriro
Copy link

kriro commented Feb 2, 2023

When I have a run-in heading in my EDUPUB publication like so:

<section aria-labelledby="sec-heading">
    <p><span aria-level="1" role="heading" id="sec-heading">Section heading (run-in)</span> Section contents.</p>
</section>

when validating with epubcheck 5.0.0 under the EDUPUB profile, I get the following error:

epubcheck error: ERROR(RSC-005): […]: Error while parsing file: section does not have a heading.

https://idpf.org/epub/profiles/edu/spec/#h.frvc45xf6cia 3rd paragraph suggests that I should be able to use aria-labelledby to associate the section with its heading, which cannot be a ranked HTML5 heading at that place due to p's content model restriction. That is why I use role="heading" and aria-level="1" as the equivalent to h1.

Is this an epubcheck issue, EDUPUB issue, or me misunderstanding the relevant spec's wording?

@rdeltour rdeltour self-assigned this Feb 3, 2023
@rdeltour rdeltour added spec: EDUPUB Impacting the support of the EDUPUB specification priority: medium To be processed and published in one of the upcoming releases type: false-positive This issue is about valid content being incorrectly rejected status: needs test case A reproducible test case is needed to move the issue forward labels Feb 3, 2023
@rdeltour rdeltour added this to the Next maintenance release milestone Feb 3, 2023
@rdeltour
Copy link
Member

rdeltour commented Feb 3, 2023

Is this an epubcheck issue, EDUPUB issue, or me misunderstanding the relevant spec's wording?

This may be a limitation in EPUBCheck, at first sight the markup looks legit.

The checks for EDUPUB are quite old and I don't remember if ARIA-defined headings are supported. I'll have a look. Thanks for the report!

@mattgarrish
Copy link
Member

Edupub is kind of dead at this point, too. There's a new education task force in the Publishing Community Group looking into publishing requirements for education. You can find some info on it here https://www.w3.org/events/meetings/9ce5bd96-5a87-4448-a4ba-7fafafb9dcdf/20230208T100000

@rdeltour rdeltour linked a pull request Apr 28, 2023 that will close this issue
@rdeltour rdeltour added status: has PR The issue is being processed in a pull request and removed status: needs test case A reproducible test case is needed to move the issue forward labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium To be processed and published in one of the upcoming releases spec: EDUPUB Impacting the support of the EDUPUB specification status: has PR The issue is being processed in a pull request type: false-positive This issue is about valid content being incorrectly rejected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants