New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[motion-1] Make offset-position more specific #499
Comments
The description of Also, the description of
These words sound like we shouldn't take cc @tabatkins for this issue because we have some wpt for |
Yeah, I have absolutely no idea what that spec text is trying to say or why it's trying to say it. The entire property seems very confused; it appears to think that 'offset' is a form of absolute positioning, rather than a transform. Here, let me just go rewrite the whole thing to make sense. brb |
Thanks, Tab! From what I've understood from Eric is that in case of offset-position being specified, we should ignore previous position of the element (e.g. left and top properties) and just start offseting it from 0, 0 of containing block. But in this case, do we really need this property if we can have the same effect of having the start position of our path from left and top properties? Maybe consider deleting it at all? Or start the offset not from 0, 0 of containing block, but rather from the computed position of the element? |
It's properly got nothing to do with top/left; the default starting point is just "where the box is at the end of layout" (then adjusted by |
Ah you know what, iirc the Motion spec used to be defined on top of abspos, rather than being a transform; offset-position (and -anchor) were never properly rewritten after the change. Okay, so summary of changes in 2823e66:
While doing this I realized that the specified behavior of Does this look good to y'all? |
Looks good to me for this simplification. Thanks. |
Currently offset-position says that when it's specified with position it:
But it's not clear if it should calculate the initial position from the computed position (left + top properties, for example) + offset-position. Or it should be containing block (0, 0) + offset-position, ignoring the left, top properties.
And taking the note into account:
I think it needs to be specified how it should interact with other properties like left, top, right, bottom. For example, if I the size of the box is determined by all of that properties, but offset-position is specified, how they should interact?
The text was updated successfully, but these errors were encountered: