Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position data isn't passed into 'new GeolocationPosition' #137

Open
jyasskin opened this issue Sep 12, 2023 · 0 comments · May be fixed by #153
Open

Position data isn't passed into 'new GeolocationPosition' #137

jyasskin opened this issue Sep 12, 2023 · 0 comments · May be fixed by #153
Assignees
Labels

Comments

@jyasskin
Copy link
Member

jyasskin commented Sep 12, 2023

Acquire a position says to "try to acquire position data", and later it says "Set position be a new GeolocationPosition passing acquisitionTime and options.enableHighAccuracy." without mentioning that position data. new GeolocationPosition then says "Initialize coord's latitude attribute to a geographic coordinate" without giving any indication of what the coordinate should be. These should be wired up.

I'd speculate that the flexibility in new GeolocationPosition might have originally been to allow users to override their real position, but that should probably be handled in request a position by where permission is handled.

While someone's touching this, I also note that several of the steps after "if position is not cachedPosition" should actually be conditional on that, and not run when position has been set to cachedPosition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants