Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions Policy integration incomplete #75

Closed
annevk opened this issue May 5, 2021 · 4 comments
Closed

Permissions Policy integration incomplete #75

annevk opened this issue May 5, 2021 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented May 5, 2021

It doesn't perform the "is allowed to use" check anywhere.

@marcoscaceres
Copy link
Member

so, we had it, but apparently this is covered by the Permission Spec's "request permission to use" algorithm:

#68 (comment)

cc @jyasskin, in case we need to clarify things.

@annevk
Copy link
Member Author

annevk commented May 12, 2021

Oh I see, https://www.w3.org/TR/permissions/#reading-current-states ends up looking at it. Interesting.

@marcoscaceres
Copy link
Member

Yeah, let us know if that works ok. We can update Permissions or here if needed.

@annevk
Copy link
Member Author

annevk commented May 12, 2021

I think that works. There might be some cleanup to be done around settings objects, but that's out-of-scope for this issue. Thanks!

@annevk annevk closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants