Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section 5.3.1 (input type="image") as written can lead to non-interoperable implementations #150

Closed
joanmarie opened this issue Sep 26, 2018 · 4 comments

Comments

@joanmarie
Copy link
Contributor

joanmarie commented Sep 26, 2018

I'm seeing inconsistent implementations of the accessible name for input type="image" with a title attribute. More specifically, WebKit and Gecko expose the value of the title attribute; Blink exposes "Submit". Looking at how section 5.3.1 is written, I would argue both are correct due to item 4 in the current spec text:

5.3.1 input type="image" Accessible Name Computation

  1. If the control has an aria-label or an aria-labelledby attribute the accessible name is to be calculated using the algorithm defined in Accessible Name and Description: Computation and API Mappings 1.1.
  2. Otherwise use alt attribute
  3. Otherwise use value attribute
  4. Otherwise the user agent may provide an accessible name via a localized string of the phrase "Submit Query"
  5. Otherwise use title attribute
  6. If none of the above yield a usable text string there is no accessible name

This seems bad for interoperability.

Note: At the present time, the ARIA Working Group has a test case for the scenario. I was going to provide a patch to fix the issue in Blink, but technically they don't seem to have a bug.

@stevefaulkner
Copy link
Contributor

Hi @joanmarie how would you change the above? Note that I wrote most of the these an age ago (6 years hmmm), pretty much based on what i found was implemented at the time

@joanmarie
Copy link
Contributor Author

If you swap the order of 4 and 5, the Blink would have a bug because they are not using the title.

@stevefaulkner
Copy link
Contributor

@joanmarie
Copy link
Contributor Author

Suh-weet! :) Got my fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1246724

Thanks much @stevefaulkner!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants