Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of identical-appearing characters #1510

Closed
xfq opened this issue Apr 11, 2022 · 2 comments
Closed

Display of identical-appearing characters #1510

xfq opened this issue Apr 11, 2022 · 2 comments
Labels
pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:webgpu https://gpuweb.github.io/gpuweb/

Comments

@xfq
Copy link
Member

xfq commented Apr 11, 2022

Proposed comment

Shader Module Creation
https://gpuweb.github.io/gpuweb/#shader-module-creation

Note: User agents should consider issuing developer-visible warnings in most or all situations where display of two names with different code point sequences look the same to the reader, such as ones same under canonical equivalence with Normalization Form C (NFC) or characters that look similarly.

NFD is not mentioned here, and there is no clear definition for "characters that look similarly". You may want to refer to the charmod-norm document, which is about this issue.

Instructions:

This follows the process at https://w3c.github.io/i18n-activity/guidelines/review-instructions.html

  1. Create the review comment you want to propose by replacing the prompts above these instructions, but LEAVE ALL THE INSTRUCTIONS INTACT

  2. Set a label to identify the spec: this starts with s: followed by the spec's short name. If you are unable to do that, ask a W3C staff contact to help.

  3. Ask the i18n WG to review your comment.

  4. After discussion with the i18n WG, raise an issue in the repository of the WG that owns the spec. Use the text above these instructions as the starting point for that comment, but add any suggestions that arose from the i18n WG. In the other WG's repo, add an 'i18n-needs-resolution' label to the new issue. If you think any of the participants in layout requirements task force groups would be interested in following the discussion, add also the appropriate i18n-*lreq label(s).

  5. Delete the text below that says 'url_for_the_issue_raised', then add in its place the URL for the issue you raised in the other WG's repository. Do NOT remove the initial '§ '. Do NOT use [...](...) notation – you need to delete the placeholder, then paste the URL.

  6. Remove the 'pending' label, and add a 'needs-resolution' tag to this tracker issue.

  7. If you added an *lreq label, add the label 'spec-type-issue', add the corresponding language label, and a label to indicate the relevant typographic feature(s), eg. 'i:line_breaking'. The latter represent categories related to the Language Enablement Index, and all start with i:.

  8. Edit this issue to REMOVE ALL THE INSTRUCTIONS & THE PROPOSED COMMENT, ie. the line below that is '---' and all the text before it to the very start of the issue.


This is a tracker issue. Only discuss things here if they are i18n WG internal meta-discussions about the issue. Contribute to the actual discussion at the following link:

§ url_for_the_issue_raised

@xfq xfq added pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:webgpu https://gpuweb.github.io/gpuweb/ labels Apr 11, 2022
@xfq
Copy link
Member Author

xfq commented Apr 11, 2022

Ah, I just found that this issue and #1508 are very similar. Maybe we can merge them into one issue.

@xfq
Copy link
Member Author

xfq commented Apr 24, 2022

The spec text has been changed. I'll close this and re-review the current text in https://gpuweb.github.io/gpuweb/wgsl/#identifier-comparison

@xfq xfq closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Issue not yet sent to WG, or raised by tracker tool & needing labels. s:webgpu https://gpuweb.github.io/gpuweb/
Projects
None yet
Development

No branches or pull requests

1 participant