Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to external style sheet #39

Closed
xfq opened this issue Mar 31, 2023 · 5 comments
Closed

Link to external style sheet #39

xfq opened this issue Mar 31, 2023 · 5 comments

Comments

@xfq
Copy link
Member

xfq commented Mar 31, 2023

<link rel="stylesheet" data-import href="https://w3c.github.io/i18n-drafts/style/respec_2022.css">

Currently, we link to a style sheet on GitHub, but the Pubrules doesn't allow this, because the link may be broken (for example, GitHub may be down or go bankrupt), so we should probably copy this file to this repo. This is also consistent with our Process.

If many of our documents use this file, we can also consider putting it on the W3C server and asking the Webmaster to add an exception.

@r12a
Copy link
Contributor

r12a commented Mar 31, 2023

If many of our documents use this file, we can also consider putting it on the W3C server and asking the Webmaster to add an exception.

We also have a way of automatically including the style sheet into the main html doc before publishing, which we also use for the gap analysis documents. That's what the data-import attribute is for.

@xfq
Copy link
Member Author

xfq commented Apr 2, 2023

If many of our documents use this file, we can also consider putting it on the W3C server and asking the Webmaster to add an exception.

We also have a way of automatically including the style sheet into the main html doc before publishing, which we also use for the gap analysis documents. That's what the data-import attribute is for.

Ah, OK. Have we applied this to i18n-glossary already?

@r12a
Copy link
Contributor

r12a commented Apr 3, 2023

Since Addison added it to a recent commit, afaict, no. We'd need to go through the first part of the publication process and look at the file in .tmp to check whether the styling is there.

@aphillips
Copy link
Collaborator

I fixed this today, switching to a style element with ReSpec's data-import attribute. I think you can close?

@xfq
Copy link
Member Author

xfq commented Apr 25, 2023

Yes. Thank you!

@xfq xfq closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants