Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Share API > 2020-06-05 #114

Closed
aphillips opened this issue Apr 22, 2020 · 4 comments
Closed

Web Share API > 2020-06-05 #114

aphillips opened this issue Apr 22, 2020 · 4 comments
Assignees
Labels
FPWD First Public Working Draft published. REVIEW REQUESTED

Comments

@aphillips
Copy link

Note that the i18n WG prefers groups to run a self-review around the time of FPWD. Let us know when you have done it. Get advice on how to do that at https://www.w3.org/International/review-request#selfreview.

If you still want us to review your spec, please provide the information below.

In the issue title above add the document name followed by the date of this request.

Other comments:

Hello,

The WebApps WG would welcome your review of the Web Share API FPWD [1].

If you have any comments or questions following your review, please could you file them as issues on the Web Share API Github repository [2].

If you're able to complete your review by Friday 5 June 2020 it would be appreciated. Thank you.

Léonie
[1]
https://www.w3.org/TR/web-share/
[2]
https://github.com/w3c/web-share/issues/

-- Director @TetraLogical

@aphillips aphillips added REVIEW REQUESTED pending The WG needs to assign a reviewer. FPWD First Public Working Draft published. labels Apr 22, 2020
@aphillips aphillips added this to Review requested in Review radar Apr 22, 2020
@aphillips aphillips removed the pending The WG needs to assign a reviewer. label Apr 23, 2020
@xfq
Copy link
Member

xfq commented Apr 24, 2020

I have reviewed this document. This only issue I found was that the text and title members can't be associated with language and (base) direction metadata (or label language/direction changes inline).

We already have an issue for that: w3c/i18n-activity#248

@himorin
Copy link
Contributor

himorin commented Apr 27, 2020

I did not find any additional point, neither.
Section 3.1 might be required to be rewritten following addition of lang/dir (e.g. some sharing method may have such capability), but it's non-normative.

@aphillips aphillips moved this from Review requested to In review in Review radar Apr 30, 2020
@aphillips aphillips moved this from In review to Awaiting comment resolution in Review radar May 7, 2020
@aphillips aphillips moved this from Awaiting comment resolution to In review in Review radar May 7, 2020
@aphillips
Copy link
Author

I pulled this back from "awaiting comment resolution" because in the course of addressing action-896 I noticed a new comment w3c/i18n-activity#901

@aphillips aphillips moved this from In review to Awaiting comment resolution in Review radar May 14, 2020
@aphillips
Copy link
Author

Replaced with new request: #129

@aphillips aphillips moved this from Awaiting comment resolution to Completed in Review radar Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FPWD First Public Working Draft published. REVIEW REQUESTED
Projects
Review radar
Completed
Development

No branches or pull requests

3 participants