Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Context 2022-09-22 > 2022-11-03 #193

Closed
kalyanaj opened this issue Sep 30, 2022 · 2 comments
Closed

Trace Context 2022-09-22 > 2022-11-03 #193

kalyanaj opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
close? FPWD First Public Working Draft published. REVIEW REQUESTED

Comments

@kalyanaj
Copy link

Name of your specification

Trace Context Level 2

URL of your specification

https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2Ftrace-context-1%2F&doc2=https%3A%2F%2Fwww.w3.org%2FTR%2F2022%2FWD-trace-context-2-20220929%2F

Do you need a reply by a particular date?

We are looking to get to CR status before end of year

Please point to the results of your own self-review

w3c/trace-context#498

Where and how should the i18n WG raise issues?

https://github.com/w3c/trace-context/issues

Pointer to any explainer for the spec

https://github.com/w3c/distributed-tracing-wg/blob/main/EXPLAINER.md

Other comments

What: The main difference from Trace Context Level 1 (which is already in recommendation status) is the ability to express whether at least a part of the traceID has been randomly (or pseudo-randomly) generated.
Why: This enables downstream systems to use the trace ID for sampling purposes or for sharding purposes.
How: This is achieved by the introduction of a new flag called "Random Trace ID flag". If the newly introduced random-trace-id flag is set, at least the right-most 7 bytes of the trace-id MUST be randomly (or pseudo-randomly) generated.

@kalyanaj kalyanaj added FPWD First Public Working Draft published. pending The WG needs to assign a reviewer. REVIEW REQUESTED labels Sep 30, 2022
@xfq xfq added this to Review requested in Review radar Sep 30, 2022
@aphillips aphillips changed the title Trace Context 2022-09-22 Trace Context 2022-09-22 > 2022-11-03 Oct 3, 2022
@aphillips aphillips self-assigned this Oct 6, 2022
@aphillips aphillips removed the pending The WG needs to assign a reviewer. label Oct 6, 2022
@aphillips aphillips moved this from Review requested to In review in Review radar Oct 6, 2022
@aphillips aphillips moved this from In review to Awaiting comment resolution in Review radar Oct 23, 2022
@kalyanaj
Copy link
Author

Thanks @aphillips for the review for Trace Context Level 2.

The three issues filed from this review (https://github.com/w3c/trace-context/issues?q=label%3Ai18n-needs-resolution+) have been addressed/closed/backported to our Level 2 branch. Wanted to check if we can go ahead close this issue. Thanks!

w3c/trace-context#506
w3c/trace-context#507
w3c/trace-context#508

@aphillips
Copy link
Contributor

@kalyanaj Thanks for the pointer. We will close the books on this review. Thanks.

@aphillips aphillips moved this from Awaiting comment resolution to Completed in Review radar Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
close? FPWD First Public Working Draft published. REVIEW REQUESTED
Projects
Review radar
Completed
Development

No branches or pull requests

2 participants