Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter-styles tests broken #31

Closed
r12a opened this issue Sep 23, 2020 · 5 comments
Closed

Counter-styles tests broken #31

r12a opened this issue Sep 23, 2020 · 5 comments

Comments

@r12a
Copy link
Contributor

r12a commented Sep 23, 2020

https://w3c.github.io/i18n-tests/results/custom-counter-styles

I believe these worked fine originally, but for some reason they no longer do. In Firefox the test and ref appear to be using different fonts.

The easiest way to fix this is to remove the content of the support/create.ref function, which will make the list marker and the content appear side by side.

Since that fix makes it much harder to check that all is correct, perhaps we could figure out how to make the overaly approach work? I spent some time on it this morning, but drew a blank. @xfq @himorin any ideas?

@himorin
Copy link
Contributor

himorin commented Sep 23, 2020

sorry to ask this kind of thing, but do you have specific one? Using Firefox 81.0, I could not find one which should pass (by means, marked as implemented/supported in caniuse etc.) but show red part...

@r12a
Copy link
Contributor Author

r12a commented Sep 23, 2020

Here's what i see for the very first one, and for many others (using FF 80).

Screenshot 2020-09-23 at 10 35 20

In this case, the overlap is fixed by assigning lang="ar" to the encapsulating div, but that doesn't work completely for the Farsi test that follows (ie. when setting lang to fa). It also introduces some font fallback issues on my system.

@himorin
Copy link
Contributor

himorin commented Sep 23, 2020

it's my capture on Windows10/Firefox 81.0 (was the same for 80.0.6 on backup).

image

both red text and li::marker say these are rendered using 'Times New Roman'. I think no additional arabic font (than OS default in Japanese edition) installed on the Windows.

@xfq
Copy link
Member

xfq commented Sep 24, 2020

FWIW, my result is the same as Atsushi's (in Firefox 81.0 on macOS 10.15.6).

@r12a
Copy link
Contributor Author

r12a commented Jan 23, 2023

This no longer seems problematic for me, so closing.

@r12a r12a closed this as completed Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants