Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage of terminology 'codepoints' in patch subset spec. #73

Closed
himorin opened this issue Dec 17, 2021 · 6 comments
Closed

usage of terminology 'codepoints' in patch subset spec. #73

himorin opened this issue Dec 17, 2021 · 6 comments
Labels
i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Patch Subset Solution includes something specific to patch subset method

Comments

@himorin
Copy link
Contributor

himorin commented Dec 17, 2021

(during i18n discussion,) I personally felt that a word 'codepoints' are used as identifier of both "set of codepoints" (target codepoints which client requests and are transferred from server) and "set of glyph substitutions of font" (handled as subset of font), and I wonder this might be confusing for some readers.

@himorin himorin added i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Patch Subset Solution includes something specific to patch subset method labels Dec 17, 2021
@svgeesus
Copy link
Contributor

Perhaps Codepoint reordering should be named something more precise, like Index Generation. Because it takes codepoints as input, but does not generate new codepoints; instead it generates index values.

@himorin
Copy link
Contributor Author

himorin commented Jan 7, 2022

I would agree to the analysis, although some sections other than the section on codepoint reordering also need to be updated - which refer outputs from reordering.
Also I suppose it might be better to think about codepoint_ordering also?

@svgeesus svgeesus mentioned this issue Feb 15, 2022
8 tasks
@svgeesus
Copy link
Contributor

@garretrieger @litherum this one is not moving forward, let's discuss on the call today?

@svgeesus
Copy link
Contributor

@himorin does the revised wording at 4.1. Font Subset and 4.7. Codepoint Reordering resolve your comment?

As you will see at 4.3.3. PatchRequest codepoint and glyph index are now being used as distinct concepts.

@himorin
Copy link
Contributor Author

himorin commented Jun 21, 2022

@svgeesus Thank you for updates. I believe current terminologies resolve my confused points, and I am happy to close this.

@himorin himorin closed this as completed Jun 21, 2022
@r12a
Copy link

r12a commented Jun 21, 2022

micronit: Although i'm always tempted to write codepoint (one word), i think the more usual way (per Unicode Standard) is code points (two words). I'm sure it's perfectly understandable as is, though, so just mentioning this to be pedantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-tracker Group bringing to attention of Internationalization, or tracked by i18n but not needing response. Patch Subset Solution includes something specific to patch subset method
Projects
None yet
Development

No branches or pull requests

3 participants