Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-thread "reserved key codes" is problematic #32

Open
annevk opened this issue Sep 7, 2017 · 2 comments
Open

Cross-thread "reserved key codes" is problematic #32

annevk opened this issue Sep 7, 2017 · 2 comments

Comments

@annevk
Copy link

annevk commented Sep 7, 2017

You need to queue a task to update this. Currently the way you've written things the "in parallel" thread could update it, then hang for seconds, then add another key, etc. That wouldn't give very deterministic behavior.

@garykac
Copy link
Member

garykac commented Sep 7, 2017

Thanks!

@annevk
Copy link
Author

annevk commented Sep 8, 2017

I'm not sure that's the right fix. You presumably still want to go in parallel first, to obtain permission and such or allow this to be rejected for some out-of-process reason?

@garykac garykac reopened this Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants