Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkeypatching UI Events is problematic #33

Open
annevk opened this issue Sep 7, 2017 · 3 comments
Open

Monkeypatching UI Events is problematic #33

annevk opened this issue Sep 7, 2017 · 3 comments

Comments

@annevk
Copy link

annevk commented Sep 7, 2017

You redefine how dispatching key events works. Please make sure that's tightly coupled with the relevant prose in UI Events (it might be that such prose there is still lacking, I recommend encouraging the editors to finally add it if so). Otherwise we'll just end up with a giant mess and nobody being really sure in what order things actually happen.

@garykac
Copy link
Member

garykac commented Sep 7, 2017

The prose in UI Events is indeed lacking -- which is my fault. It's on my list of things to cleanup, but I haven't had time to devote to it yet.

I added a bug in UIEvents to track this: w3c/uievents#158

@garykac
Copy link
Member

garykac commented Sep 7, 2017

FWIW, my general plan the key dispatch is to update the UIEvents algorithm and have callouts to the KeyboardLock and Fullscreen specs.

@annevk
Copy link
Author

annevk commented Sep 8, 2017

That sounds like a good plan to me. That's what we generally end up doing optionally with some notes to point out the callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants