Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "type" to the examples of Screenshot object #44

Open
webmaxru opened this issue Oct 3, 2021 · 0 comments
Open

Adding "type" to the examples of Screenshot object #44

webmaxru opened this issue Oct 3, 2021 · 0 comments

Comments

@webmaxru
Copy link

webmaxru commented Oct 3, 2021

I think that adding type to the Example 1 and Example 2 of the Screenshot object will improve developer experience.

This member comes from ImageResource object and it's optional (so actually the examples are syntactically correct). But all other optional members are included there and it might cause some confusion (or at least some extra time for the research). To improve DX, I suggest adding "type": "image/png", to both examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant