Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All String should be localizable #1136

Closed
calidion opened this issue Jun 25, 2024 · 1 comment
Closed

All String should be localizable #1136

calidion opened this issue Jun 25, 2024 · 1 comment

Comments

@calidion
Copy link

All manifest strings can be able to use localized strings for internationalization.
They should support at lease two types of definitions:

  1. Direct one string for one language only
"name":  "Web App"   // English only

or

"name":  "网站应用"  // Chinese Only
  1. Multiple languages support
lang: "en",   // fallback language if browser meets none locale strings listed
"name":  {
"en":  "Web App",    // fallback for all en-* browsers or for general  en-* users
"en-US":  "Web App",   // specific string for localized en
"zh": "网站应用”, // fallback for all zh-* browsers  or for general  zh-* users
"zh-CN": "网站应用”, // specific string for localized zh
...
@christianliebel
Copy link
Member

@calidion Thank you for reporting this issue. We are currently addressing this scenario as part of PR #1101. Feel free to subscribe to this PR and join the discussion there. I will close this issue as a duplicate of #676.

@christianliebel christianliebel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants