You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
Assuming we do what's suggested in #100 (rename to something like depthPrecision and standardize values on an API unit), then why couldn't users change depthPrecision with applyConstraints? Constraints let tabs negotiate for a shared resource, and I see no reason UAs couldn't handle this.
Other issues:
Typo: We can't have unit in both MediaTrackConstraintSet and MediaTrackConstraints, since the latter is derived from the former.
Use DOMString instead of WebIDL enum in constraints (see facingMode).
To support mandatory constraints (e.g. applyConstraints({ depthPrecision: { exact: "m" } }), the type in MediaTrackConstraintSet needs to be ConstrainDOMString (again like facingMode).
Default values must be avoided in MediaTrackConstraintSet, as a rule. *
*) because default values get implicitly inserted by webidl binding code to provide implementations with invariants, which is great, except MediaTrackConstraintSet is reused in advanced where the semantics of absence differs from providing a (default) value.
May be moot because of #100 - but otherwise I think the promise should only be rejected based on this if depthMapUnit is mandatory.
The text was updated successfully, but these errors were encountered: