Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Track Stats API] The stats API should be synchronous #105

Closed
henbos opened this issue Sep 8, 2023 · 1 comment · Fixed by #106
Closed

[Track Stats API] The stats API should be synchronous #105

henbos opened this issue Sep 8, 2023 · 1 comment · Fixed by #106

Comments

@henbos
Copy link
Contributor

henbos commented Sep 8, 2023

In response to #98, background discussion there or this Virtual Interim recording from when it was discussed.

The performance concern I raised earlier about post tasks raised earlier are not valid, so if people see value in a sync getter API and it is easy to implement, we should do that.

Implementations that does not PostTask-update the counters just need to implement a cache instead as to run-to-completion principles.

I'll prepare a PR, then we can decide at TPAC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants