Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Track Stats API] Rename "videoStats" to "stats" #107

Closed
henbos opened this issue Sep 12, 2023 · 1 comment · Fixed by #110
Closed

[Track Stats API] Rename "videoStats" to "stats" #107

henbos opened this issue Sep 12, 2023 · 1 comment · Fixed by #110
Assignees
@henbos
Labels
PR exists

Comments

@henbos
Copy link
Contributor

henbos commented Sep 12, 2023

As pointed out during the TPAC presentation of PR #106,

Tracks are by definition either audio or video, so we should rename this to track.stats.
@henbos henbos self-assigned this Sep 12, 2023
This was referenced Sep 12, 2023
Merged
Closed
Closed
@henbos henbos changed the title [Track Stats API] Rename "videoStats" to "stats"? [Track Stats API] Rename "videoStats" to "stats" Sep 13, 2023
@henbos
Copy link
Contributor Author

henbos commented Sep 13, 2023

I'll make a PR once #106 has merged

@henbos henbos mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henbos henbos

Labels
PR exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename track.videoStats to track.stats henbos/mediacapture-extensions
1 participant
@henbos