Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setSinkId("") vs setSinkId(defaultDeviceId) #94

Closed
jan-ivar opened this issue Jun 11, 2020 · 0 comments · Fixed by #95
Closed

setSinkId("") vs setSinkId(defaultDeviceId) #94

jan-ivar opened this issue Jun 11, 2020 · 0 comments · Fixed by #95
Assignees

Comments

@jan-ivar
Copy link
Member

This spec defines "" to mean the "user-agent default device", e.g. status quo without this spec.

At least on macOS this OS default is dynamic and may change live. As such, these differ:

await element.setSinkId(""); // Follow the dynamic OS default 
await element.setSinkId(defaultDeviceId); // Stop following the dynamic OS default 

With the second one, the element stops responding to user changes in the OS.

The problem is the spec right now implies both of these may be called without consent, which seems wrong: "If the application is not permitted to play audio through the device identified by sinkId, reject p ", and: "The specification adds no permission requirement to the default audio output device.".

We propose changing the spec here to require consent for anything other than "", since it allows JS to stop following the (potentially changing) OS default, and instead track the physical device that was default at the time of the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant