Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Surface API for reading back the configured encoding bitrate(s) #43

Closed
yellowdoge opened this issue Jan 18, 2016 · 5 comments
Closed

Comments

@yellowdoge
Copy link
Member

Section MediaRecorder Properties says:

[TO DO: Provide API surface to set and read these. When that is done, this section will be removed.]

this is the issue for that TODO, for the bitrate options concretely.

(It's basically a follow up of @mreavy "improve bitrate control in MediaRecorder" #20 - discussed with @tdaede).

@mreavy
Copy link

mreavy commented Jan 19, 2016

That looks good, except that the three bitrate properties should all use the same or similar language to say that the target bitrate isn't guaranteed. I'll close #20

@yellowdoge
Copy link
Member Author

@mreavy, re. your comment, from https://rawgit.com/w3c/mediacapture-record/master/MediaRecorder.html#dictionary-mediarecorderoptions-members,

  • audioBitsPerSecond: This is a hint for the encoder and the value might only be achieved over a long time.
  • videoBitsPerSecond : This is a hint for the encoder and the value might be surpassed or not achieved.
  • bitsPerSecond: This parameter is a hint for the encoder(s) and the total value might be surpassed or not achieved at all.

@mreavy
Copy link

mreavy commented Jan 21, 2016

@miguelao :I'm sorry, I don't see a question here - those are the descriptions that need to be synchronized, yes.

@yellowdoge
Copy link
Member Author

Oh I see, you meant that the three should say a similar thing, gotcha.

@yellowdoge
Copy link
Member Author

Closed as per #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants