-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CropTarget should probably be available to Elements and not only HTMLElements #13
Comments
Fine by me if nobody else objects. |
I'd invoke the rule that "it's easy to expand, but hard to contract". We know that it is useful on HTMLElement, If we were to expand it to Element, that is possible to do later, but contracting down from Element to HTMLElement would be much harder. That said, if you can name a specific SVG element that it makes sense to crop to, we can add that to the list of permitted arguments to ProduceCropId() without any great heartburn. But again - probably as an extension. |
Given that we have an objection, how about we dial this back until we get a use-case? Note that developers can embed their |
Is that an objection? While I can understand the 'it is easy to expand' part of the argument, I do not understand the motivation to restrict to HTMLElement.
Can you provide a reason why we should not expose to Element?
Such a time has come :)
As an extension to which spec? |
|
It seems Element is a good fit for CropTarget. This includes HTMLElement but also SVG constructs (how about cropping to a nice SVG element with some animations?)
That would seem more consistent with https://fullscreen.spec.whatwg.org which is defining requestFullScreen at Element level.
The text was updated successfully, but these errors were encountered: