Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible duplication of requirements #125

Closed
annevk opened this issue Nov 15, 2019 · 3 comments · Fixed by #177
Closed

Possible duplication of requirements #125

annevk opened this issue Nov 15, 2019 · 3 comments · Fixed by #177

Comments

@annevk
Copy link
Member

annevk commented Nov 15, 2019

Under DisplayMediaStreamConstraints it states that video being false MUST be rejected. Unless I'm missing something this is already required as part of getDisplayMedia(). And the latter is a much better style as the order relative to other rejections is clear.

@eladalon1983
Copy link
Member

Thought - what if we specified things in such a way that {video: false} weren't even possible?

So instead of:

(boolean or MediaTrackConstraints) video = true;

Have:

MediaTrackConstraints video = {};

We could accept video = true for a few releases and issue a warning, then deprecate.
(Note that the empty dictionary evaluates as true. If only true also auto-converted to the empty dictionary... 😄)

@eladalon1983
Copy link
Member

This currently reads:

video of type (boolean or MediaTrackConstraints), defaulting to true
---
If true, it requests that the returned MediaStream contain a video track.
If a Constraints structure is provided, it further specifies desired processing
options to be applied to the video track rendition of the display surface chosen
by the user.
If false, the request MUST be rejected with a TypeError.

If we remove "If false, the request MUST be rejected with a TypeError" we end up with text that addresses 2 out of 3 possible values. Are we sure this is an improvement? Or is the suggestion to replace MUST with "must," lowercase?

@annevk
Copy link
Member Author

annevk commented Jun 3, 2021

It needs to be an informal description without implementation requirements. Lowercasing must does not help with that, it would still be duplicating a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants