Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SameObject] should not be used in FrozenArray attributes #327

Closed
rakuco opened this issue Apr 26, 2024 · 5 comments
Closed

[SameObject] should not be used in FrozenArray attributes #327

rakuco opened this issue Apr 26, 2024 · 5 comments

Comments

@rakuco
Copy link
Member

rakuco commented Apr 26, 2024

https://webidl.spec.whatwg.org/#SameObject says

The [SameObject] extended attribute must not be used on anything other than a read only attribute whose type is an interface type or object.

MediaMetadata.chapterInfo and ChapterInformation.artwork are FrozenArray types, which do not qualify according to the spec.

@marcoscaceres
Copy link
Member

marcoscaceres commented Apr 27, 2024

That’s weird, because Array is kinda an interface type. Did this come up before in another context? (We should probably get WebIDL to explicitly say this is not allowed in a note or something)

@rakuco
Copy link
Member Author

rakuco commented Apr 29, 2024

Did this come up before in another context? (We should probably get WebIDL to explicitly say this is not allowed in a note or something)

I was checking [SameObject]'s description in the context of another spec and stumbled upon the attributes here. But I agree this is confusing, so I've filed whatwg/webidl#1402 to get some clarification.

@marcoscaceres
Copy link
Member

marcoscaceres commented May 13, 2024

@rakuco what's the latest? Seems there is no resolution yet on the IDL side? Still unsure if this is a problem or not.

@rakuco
Copy link
Member Author

rakuco commented May 13, 2024

I was hoping for a quicker resolution of the Web IDL issue I filed. If you prefer, we can close this issue and I can reopen it if/when there's an outcome there.

@marcoscaceres
Copy link
Member

Yeah, let’s close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants