Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON: Example Accidentals, boolean property values must not be quoted #307

Closed
paul-bayleaf opened this issue Aug 31, 2023 · 2 comments
Closed

Comments

@paul-bayleaf
Copy link

The MNX example Accidentals has quoted the boolean property value "true".
Lines 69, 125, 167.

Suggested fix: remove quotes from boolean values.

I have written a JSON schema for MNX, is this of interest? If so I can prepare a pull request.

@mscuthbert
Copy link
Contributor

Yes! It! Is!

@adrianholovaty
Copy link
Contributor

@paul-bayleaf Thanks for another good catch! Yes, please do open a pull request with a JSON Schema. My plan is to try to automatically generate such a schema from our documentation, but it would be very useful to get another person's perspective on it (and it would definitely come in handy in the interim). Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants