Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv value needs encoding specified #239

Closed
mfoltzgoogle opened this issue Dec 30, 2019 · 2 comments
Closed

mv value needs encoding specified #239

mfoltzgoogle opened this issue Dec 30, 2019 · 2 comments
Assignees

Comments

@mfoltzgoogle
Copy link
Contributor

The mv value in the mDNS TXT record is an integer, but the spec does not say how to encode it.

Choices include:

  1. ASCII as hex or base10
  2. Big endian (network byte order)
  3. QUIC varint

Since values are likely to remain small (< 10000), I would favor option 1 which prioritizes readability.

@chrisn
Copy link
Member

chrisn commented Dec 31, 2019

I agree, and this would be consistent as the other values in the TXT record are also readable.

As an aside, reading this part of the OSP spec, there's a reference to RFC5122 for the fp field - should this be RFC8122?

@mfoltzgoogle
Copy link
Contributor Author

Addressed by #253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants