Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCSctpTransportState: state transition clarifications #638

Merged
merged 2 commits into from Jan 20, 2017

Conversation

aboba
Copy link
Contributor

@aboba aboba commented Jan 17, 2017

Fix for Issue #635

@aboba aboba added the 1.1 label Jan 17, 2017
@lgrahl
Copy link
Contributor

lgrahl commented Jan 18, 2017

I believe calling start twice should still raise an InvalidStateError for now. Because, if not, what is supposed to happen? We have discussed this briefly in #625 starting with #625 (comment). The corresponding issue w3c/webrtc-pc#979 indicates that this still needs to be discussed.

@aboba
Copy link
Contributor Author

aboba commented Jan 18, 2017

@lgrahl I believe that calling start transitions from new to connecting and after that it is not possible to transition back to new. So if we were to throw an InvalidStateError if start is called when RTCSctpTransportState is not new, then I think this would cover the case where start is called more than once.

Update InvalidStateError conditions
@lgrahl
Copy link
Contributor

lgrahl commented Jan 18, 2017

I agree. Your latest commit has made it clear, thanks. 👍

@robin-raymond robin-raymond merged commit 8bd001b into master Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants