Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebRTC 1.0 RTCDTMFSender compatibility #737

Closed
aboba opened this issue Jul 28, 2017 · 1 comment
Closed

WebRTC 1.0 RTCDTMFSender compatibility #737

aboba opened this issue Jul 28, 2017 · 1 comment
Labels
1.0 compatibility issue

Comments

@aboba
Copy link
Contributor

aboba commented Jul 28, 2017 •
edited

To improve WebRTC 1.0 compatibility, exception throwing and the behavior of canInsertDTMF should be aligned.

Currently, construction of a RTCDtmfSender is permitted even when "telephone-event" is not included in codecs[] (setting candInsertDTMF to false), rather than throwing an exception. This is compatible with the proposed behavior in WebRTC 1.0.

insertDTMF throws an exception if the sender has been stopped, if sender.send() hasn't been called, and if "telephone-event" is not included in parameters.codecs[]. However, the conditions under which canInsertDTMF is set to true aren't specified (presumably when send(parameters) is called with "telephone-event" in parameters.codecs[]).

Related WebRTC 1.0 Isssue: w3c/webrtc-pc#1415
Related WebRTC 1.0 PR: w3c/webrtc-pc#1536
@aboba
Copy link
Contributor Author

aboba commented Sep 18, 2017

WebRTC 1.0 PR w3c/webrtc-pc#1536 has now been merged, better aligning ORTC and WebRTC 1.0 DTMF behavior. Closing this issue.

@aboba aboba closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0 compatibility issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aboba