Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of "instrumentKey" language #212

Closed
madmath opened this issue Sep 5, 2017 · 1 comment
Closed

Clarification of "instrumentKey" language #212

madmath opened this issue Sep 5, 2017 · 1 comment

Comments

@madmath
Copy link

madmath commented Sep 5, 2017

It is my understanding that "instrumentKey" is not going to be set equally by all implementers as part of the "paymentrequest" event.

self.addEventListener('paymentrequest', function(e) {
// e.instrumentKey may or may not be set.
});

The current draft text says:

The instrumentKey identifier will be passed to the payment handler to indicate the PaymentInstrument selected by the user, if any.

I can see how "if any" may indicate that instrumentKey may not be set, but I would recommend language such as "the instrumentKey identifier may be passed if a specific PaymentInstrument has been selected by the user".

cc @rsolomakhin

@rsolomakhin
Copy link
Collaborator

Resolved in a pull request. Empty string means that user has not selected an instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants