Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move normative requirements on PaymentRequestEvent to the processing model #262

Closed
domenic opened this issue Mar 16, 2018 · 0 comments
Closed

Comments

@domenic
Copy link

domenic commented Mar 16, 2018

This is similar to #261. Normally for interfaces, their attribute definitions contain normative text. But events are kind of special, and instead you want to define everything when you initialize them.

Right now you have things like

This attribute is a string that indicates the origin of the top level payee web page. The string MUST be formatted according to the "Unicode Serialization of an Origin" algorithm defined in section 6.1 of [RFC6454].

which is then contradicted by the processing model

Set the topLevelOrigin attribute of e to the origin of the top level payee web page.

Here it's setting topLevelOrigin to an origin, which is not a string.

Instead, the split should be more like

Returns a string that indicates the origin of the top level payee web page. Initialized by "Handling a PaymentRequestEvent".

(it's OK to be imprecise in this description.)

plus

Set the topLevelOrigin attribute of e to the serialization of the origin of the top level payee web page.

(Linking serialization in both cases to https://html.spec.whatwg.org/multipage/origin.html#ascii-serialisation-of-an-origin, per #260.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants