Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

canMakePayment() needs to match .show() #535

Closed
marcoscaceres opened this issue May 24, 2017 · 3 comments
Closed

canMakePayment() needs to match .show() #535

marcoscaceres opened this issue May 24, 2017 · 3 comments
Assignees
@marcoscaceres
Labels
CR-Exit

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented May 24, 2017 •
edited

We need to make sure canMakePayment() matches show() with respect to how .data is checked in .show(). We should make a note about IDL conversions that can take place there and be clear that IDL violations result in "false".
@zkoch zkoch assigned zkoch and marcoscaceres and unassigned zkoch Aug 2, 2017
@zkoch
Copy link
Contributor

zkoch commented Aug 2, 2017

@marcoscaceres, @adrianba and I thought you really wanted this one

@marcoscaceres
Copy link
Member Author

You guys are the kindest people I know 🎁 ... 💥.

@marcoscaceres marcoscaceres mentioned this issue Jan 31, 2018
Closed
ianbjacobs added a commit that referenced this issue Feb 12, 2018
@ianbjacobs
https://github.com/w3c/payment-request/issues/535
49c5ac3 
1) Align show() and canMakePayment() language regarding handlers
2) Add statement in 18.2 about matching functionality coming from
multiple spec sources.
@ianbjacobs
Copy link
Collaborator

See pull request:
#682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoscaceres marcoscaceres

Labels
CR-Exit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zkoch @marcoscaceres @ianbjacobs