Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of canMakePayment() #800

Closed
marcoscaceres opened this issue Oct 24, 2018 · 2 comments · Fixed by #806
Closed

Meaning of canMakePayment() #800

marcoscaceres opened this issue Oct 24, 2018 · 2 comments · Fixed by #806

Comments

@marcoscaceres
Copy link
Member

We discovered during testing that each implementation have slightly different definitions of "can make payment". During the F2F, we came to a consensus that "canMakePayment" means "the user agent supports the PMIs" - but it does not mean that there is a payment instrument set up. We concluded that we might add something to check if there is an active instrument in the future. I'll file a different bug for that.

@aestes
Copy link
Collaborator

aestes commented Nov 2, 2018

For reference, WebKit changed its canMakePayment() implementation to match the consensus definition: https://trac.webkit.org/r237594.

@jenan-stripe
Copy link

+1 for consistency, but I'd be pretty worried if this lands before #801. The major wallet providers have active instrument checks, and if that's not landing soon with PaymentRequest, it's a much less compelling option for merchants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants