Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[waitForUpdate]] must be set to true always after dispatch. #854

Closed
marcoscaceres opened this issue Mar 25, 2019 · 2 comments · Fixed by #855 or #857
Closed

[[waitForUpdate]] must be set to true always after dispatch. #854

marcoscaceres opened this issue Mar 25, 2019 · 2 comments · Fixed by #855 or #857
Labels

Comments

@marcoscaceres
Copy link
Member

Elsewhere, @danyao wrote:

From my reading of the spec, [[waitForUpdate]] is only set to true after updateWith() is called. Am I missing something?

Yes, indeed a small spec bug. Will send a patch.

@danyao
Copy link
Collaborator

danyao commented Mar 28, 2019

Hi @marcoscaceres! I noticed that the payer detail change algorithm also fires a PaymentRequestUpdateEvent. But in this case, the algorithm doesn't set [[waitForUpdate]] to true immediately after event dispatching. Should we make it align with the other cases?

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Mar 31, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants