Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionStatus update steps touch DOM objects in parallel #421

Open
jan-ivar opened this issue Sep 19, 2023 · 2 comments
Open

PermissionStatus update steps touch DOM objects in parallel #421

jan-ivar opened this issue Sep 19, 2023 · 2 comments

Comments

@jan-ivar
Copy link
Member

The spec says:

image

Some questions:

  1. What does "it asynchronously runs" mean compared to "it runs"?
  2. What object does "this" refer to here? I suspect we mean "status"?
  3. (As an optimization?) It seems to reference associated Document and make a determination about fully active on a background thread. Isn't that racy (e.g. with navigation)?

By the time the queued task runs, the document may no longer be "fully active", and we fire the event on a non-fully active document, which seems wrong.

It would seem more correct to move these checks into the queued task.

@jan-ivar
Copy link
Member Author

For those interested, I ran into this in w3c/mediacapture-main#862 (comment) while trying to determine whether the change event fires before or after the revocation steps (I think it's before).

@annevk
Copy link
Member

annevk commented Sep 26, 2023

It also seems like this should be described in terms of https://w3c.github.io/permissions/#permission-store changing, not in terms of a platform object changing as that makes no sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants