Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicates in Vocabulary #199

Closed
simonstey opened this issue Jun 23, 2017 · 5 comments
Closed

Duplicates in Vocabulary #199

simonstey opened this issue Jun 23, 2017 · 5 comments

Comments

@simonstey
Copy link
Contributor

simonstey commented Jun 23, 2017

While skimming through the current Vocab draft for issue #194, I noticed that "constraint operators" are listed twice:

Once as part of the Core Vocab in 3.14 Constraint Operators:

3.14.1 Or
3.14.2 Exclusive Or
3.14.3 And
3.14.4 And Sequence

and once as part of the Common Vocab in 4.6 Constraint Operators:

4.6.1 Equal to
4.6.2 Greater than
4.6.3 Greater than or equal to
4.6.4 Less than
4.6.5 Less than or equal to
4.6.6 Not equal to
4.6.7 Is a
4.6.8 Has part
4.6.9 Is part of
4.6.10 Is all of
4.6.11 Is any of
4.6.12 Is none of
4.6.13 Or
4.6.14 Exclusive Or
4.6.15 And
4.6.16 And Sequence

  1. why does the core vocab only include the logical operators but not the relational ones?
  2. why are the logical operators mentioned twice?
  3. if we keep the nonnormative common vocab of ODRL in the same document as the normative core vocab, we should avoid having duplicate names like 3.14 Constraint Operators and 4.6 Constraint Operators

(I know that this list is auto-generated)

@riannella riannella self-assigned this Jun 23, 2017
@riannella
Copy link
Contributor

  1. Main reason was that the logical ones are all explicitly mentioned in 2.6.2 Compound Constraint.
    We can do the same in 2.6.1 Atomic Constraint and perhaps explicitly list the operators we thing should be core:
  • eq

Any others??

  1. Copy/paste error (now fixed)

  2. We can prefix all the sub-section headings in Section 4 with "Common..." ??

@simonstey
Copy link
Contributor Author

We can do the same in 2.6.1 Atomic Constraint and perhaps explicitly list the operators we thing should be core:

In the Vocab, I would split the operators into logical operators and relational ones and simply link from the IM to the respective sections in the vocab.

@riannella
Copy link
Contributor

Yes, but are all the operators in the Vocab in "Core" ?

@riannella
Copy link
Contributor

See outcome of #206 issue

@riannella
Copy link
Contributor

Created relational and logical sets (and added to Core vocab)

commit: effcc01

@riannella riannella moved this from Under Current Discussion to Proposed Solution in ODRL Deliverables Review Jul 17, 2017
@riannella riannella moved this from Proposed Solution to Completed (Last Call) in ODRL Deliverables Review Aug 1, 2017
@riannella riannella removed this from Completed (Last Call) in ODRL Deliverables Review Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants