Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should touch-action behave for span? #150

Closed
NavidZ opened this issue Oct 20, 2016 · 3 comments
Closed

How should touch-action behave for span? #150

NavidZ opened this issue Oct 20, 2016 · 3 comments

Comments

@NavidZ
Copy link
Member

NavidZ commented Oct 20, 2016

I believe this test
https://github.com/w3c/web-platform-tests/blob/master/pointerevents/pointerevent_touch-action-span-test_touch-manual.html

is designed for the old days that touch-action was working on span. Can someone confirm that touch-action should have no effect on spans?
Do you think I should just remove the test or should we change the test in a way to make sure scrolling still works even though touch-action is none for the span?

@NavidZ
Copy link
Member Author

NavidZ commented Oct 20, 2016

This is a test related issue that we need to fix before v2. I wonder if it is better to have a "test" label for all issues that are related to tests only or need some test updates as well.

@mustaqahmed
Copy link
Member

The test seems stale. Since is a "non-replaced inline element", the touch-action property is not applicable here.

+1 for a new label for all issues blocking only on tests.

@NavidZ
Copy link
Member Author

NavidZ commented Nov 24, 2016

Looking again at the test it seems it correctly expects the scrolling work on the span. Not sure what I saw back then that I thought it expects the scrolling offsets as 0. Anyhow, closing this for now as it no longer applies.

@NavidZ NavidZ closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants