-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify click event firing for chorded buttons #93
Comments
does PE need to define this, or is a reference (or maybe even a non-normative note quoting that extract) to the UI Event Spec sufficient? just asking because |
You are right that |
Agreed on the call that we should add a note for this, and that either option is probably OK. To @teddink to test what Edge does and confirm they're happy with the behavior. Absent other arguments, we can just spec what Edge is already doing. |
Here is my sample: http://output.jsbin.com/yimako TEST 1 - In the blue box, perform the following: Results on Edge - pointerdown with button = 0 buttons = 1 Results on Chrome Canary with PE on – TEST 2 - Then try this: Results on Edge – Results on Chrome Canary with PE on – Chrome appears to have a bug on Test 2 since click is firing for a non-primary button. Out preference would be to just specify the Edge behavior, but are open to discussing options to changing the current behavior that Edge has on Test 2. The reason that Edge does not fire a click event for the primary button in Test 2 is that we have chosen to intertwine 'click' and CSS |
Discussed on the call today. We agree this is out of scope of Pointer Events. PE shouldn't be modifying the semantics of when click fires - that's up to UI Events. @NavidZ is going to file an issue for UI Events saying that it should perhaps add a note clarifying that changes in other (non-primary) buttons is irrelevant. Note that Chrome still has a long outstanding bug here that we're in the process of trying to fix - we fire pointerdown with button = 0 buttons = 1 |
I put in this Edge bug for tracking the work to match the Chrome intended implementation: https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8095809/ |
The UI Event Spec says:
We need to clarify what it means for chorded buttons. For example, should we fire a click in any of these sequences?
M-button-down (=> pointermove),
L-button-up (=> pointermove),
M-button-up (=> pointerup).
L-button-down (=> pointermove),
L-button-up (=> pointermove),
M-button-up (=> pointerup).
The spec is not clear here. If we agree that none of the above sequences fire clicks, then the spec can say:
Otherwise, it can define click to be a function of primary button activity:
The text was updated successfully, but these errors were encountered: