Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NotAllowedError for permission denied instead of AbortError #271

Closed
tobie opened this issue Mar 20, 2016 · 2 comments
Closed

Use NotAllowedError for permission denied instead of AbortError #271

tobie opened this issue Mar 20, 2016 · 2 comments

Comments

@tobie
Copy link
Member

tobie commented Mar 20, 2016

When the user denies permission in step 10 of 6.3.2 Starting a presentation, the promises is rejected with an AbortError.

It seems a more appropriate error would be the NotAllowedError; unless, of course, PermissionDeniedError becomes a thing.
@mounirlamouri
Copy link
Member

Using NotAllowedError here sgtm. I sent a PR: #272.

@tidoust
Copy link
Member

tidoust commented Apr 14, 2016

PR was merged, closing this issue accordingly.

@tidoust tidoust closed this as completed Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tobie @mounirlamouri @tidoust