Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSubscription() should permission check #150

Closed
nikhilm opened this issue May 27, 2015 · 2 comments
Closed

getSubscription() should permission check #150

nikhilm opened this issue May 27, 2015 · 2 comments

Comments

@nikhilm
Copy link

nikhilm commented May 27, 2015

related to #116, the spec should state to check permission and fail with PermissionDeniedError.

@martinthomson
Copy link
Member

I think that this is simple. getSubscription doesn't need to check permissions, it only needs to retrieve the current subscription. If the origin doesn't have permission, then this retrieval had better result in null.

I think that the current steps are fine. I could add a point to the algorithm that notes that an worker without permission will always have no subscription.

@martinthomson
Copy link
Member

I'm going to close this one. The current algorithm is correct based on my reasoning above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants