Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ID generation for enum entries #151

Closed
wants to merge 3 commits into from

Conversation

lanthaler
Copy link
Contributor

No description provided.

@lanthaler
Copy link
Contributor Author

I've added another small fix so that RFC2119 keywords do not get lowercased. I've also added the build so that you can merge everything easily.

Thanks a lot

@darobin
Copy link
Contributor

darobin commented Mar 1, 2013

Thanks a lot for the patch! I'm closing this PR without applying it due to issues with it, but I've taken the important parts of your patch and applying them directly so that you should normally have everything working the way you want.

I didn't take the PR because:

  • It does two different things (the RFC2119 part is a separate issue, and already has a PR)
  • There were a few strange things in the code, e.g. str.replace("") on its own.

Thanks a lot!

I'll ship a release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants