Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectAllChildren method specifies that it selects characters if passed a text node #125

Closed
darinadler opened this issue Sep 19, 2020 · 0 comments · Fixed by #136
Closed

Comments

@darinadler
Copy link

The selectAllChildren method steps indicate that the range should be created with the node and the length of the that node. However, the current version of web platform tests, the function’s name, and the WebKit engine all agree that this should select only children, not text node characters. I’m guessing that the web-compatible behavior is also the behavior that makes logical sense given name’s explicit mention of children. Instead of using the length of the node the algorithm should use the node’s number of children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants