Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify extraneous characters after names #51

Closed
cvazac opened this issue Jan 18, 2018 · 1 comment
Closed

clarify extraneous characters after names #51

cvazac opened this issue Jan 18, 2018 · 1 comment

Comments

@cvazac
Copy link
Contributor

cvazac commented Jan 18, 2018

It is currently unspecified as to whether extraneous characters following metric-name should be ignored.

We ignore extraneous characters found after a server-timing-param-value, so I'm inclined to do the same for metric-names.

Example:

Server-Timing: metric=;dur=123.4

Note: = is not a legal token character.

Options:

  1. parsing should "keep going", yielding:
    name=metric
    duration=123.4

  2. parsing should stop, yielding:
    name=metric
    duration=0

cc @yoavweiss

@yoavweiss
Copy link
Contributor

I think it makes sense for us to "keep going", drop parsing when a non-token-char is hit and skip till the next delimiter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants