Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong English phrase in "Ruby character size and character placement" #71

Closed
himorin opened this issue Nov 23, 2021 · 2 comments · Fixed by #76
Closed

wrong English phrase in "Ruby character size and character placement" #71

himorin opened this issue Nov 23, 2021 · 2 comments · Fixed by #76

Comments

@himorin
Copy link
Contributor

himorin commented Nov 23, 2021

In section "Ruby character size and character placement", leading sentence is

The size of the ruby characters and their placement in the inline direction relative to the base characters is as follows:

but inline direction should be block direction, since this part discusses about linefeed.
@Manoj0Marmat
Copy link

@himorin sir can i help ?

@himorin himorin mentioned this issue Dec 2, 2021
Merged
@himorin
Copy link
Contributor Author

himorin commented Dec 2, 2021

Although it seems conflicting with #57, checked the subsection and proposed text as PR. (could require rebase or update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed text in "Ruby character size and character placement" subsection himorin/simple-ruby
2 participants
@himorin @Manoj0Marmat