Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force "prepare for TR" metadata setting for Bikeshed specs #128

Closed
tidoust opened this issue Mar 9, 2022 · 2 comments · Fixed by #129
Closed

Force "prepare for TR" metadata setting for Bikeshed specs #128

tidoust opened this issue Mar 9, 2022 · 2 comments · Fixed by #129
Labels
enhancement Enhancement to an existing feature

Comments

@tidoust
Copy link
Member

tidoust commented Mar 9, 2022

Initially raised against Bikeshed in speced/bikeshed#2242.

Bikeshed does not run a series of "fixups" to comply with PubRules by default. These need to be enabled through the Prepare for TR metadata setting. The action should take care of that automatically.

This has not been caught before because the PubRules checker remained somewhat lax on some of the rules. It now (starting March 3rd) enforces the order of stylesheets in particular, and automated publications of Bikeshed specs to TR no longer work as a result.

Although that setting is only needed to publish specs to TR, I would argue that the setting should be set for the generation of the Editor's Draft as well, so that the Editor's Draft and the TR version remain as close as possible.

@sidvishnoi
Copy link
Member

For now, I think we should enable it for TR only to avoid breaking ED/gh-pages spec workflows.

@tidoust
Copy link
Member Author

tidoust commented Mar 10, 2022

For now, I think we should enable it for TR only to avoid breaking ED/gh-pages spec workflows.

That's good for now. What I'm worried about is that editors and group participants probably look at the Editor's Draft most of the times, meaning that there will be fewer eyes on the TR version, and so fewer eyes to spot styling issues that could potentially arise when the order of stylesheets gets changed. I wouldn't expect that to be a common problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants