Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator incorrectly claims "menu" role is invalid #1706

Closed
svgeesus opened this issue Feb 16, 2023 · 4 comments
Closed

Validator incorrectly claims "menu" role is invalid #1706

svgeesus opened this issue Feb 16, 2023 · 4 comments

Comments

@svgeesus
Copy link
Contributor

svgeesus commented Feb 16, 2023 •
edited
Loading

Trying to publish the FPWD of web animations 2, I get 194 html validation errors which is way too many to fix manually on generated html.

Most of them are

Bad value “menu” for attribute “role” on element “aside”.

This is correct html, and the validator is wrong.

menu role linked from 4.3 Managing Focus and Supporting Keyboard Navigation
@svgeesus svgeesus mentioned this issue Feb 16, 2023
Closed
@xfq
Copy link
Member

xfq commented Feb 17, 2023

This should probably be filed against https://github.com/validator/validator/issues

@nschonni
Copy link
Contributor

speced/bikeshed#2476 (comment)

@annevk
Copy link
Member

annevk commented Feb 17, 2023

Indeed, the validator is correct. Bikeshed is wrong.

@svgeesus
Copy link
Contributor Author

Ah, cheers for filing that. Easy fix then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nschonni @annevk @svgeesus @xfq