Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of L.2.1 changes across the whole document - status #392

Open
liamquin opened this issue Mar 15, 2018 · 3 comments
Open

Review of L.2.1 changes across the whole document - status #392

liamquin opened this issue Mar 15, 2018 · 3 comments

Comments

@liamquin
Copy link

  • References to the SVG DTD have been removed.
    yes

  • IDL has been updated to use Web IDL syntax.
    How would i tell?

  • Added "length" attribute and indexed property access to all list interfaces.
    Seems to be there on at least chrome and firefox. I wrote some tests, which
    pass, but only tested read-only access as that's all that the spec requires.
    Have not tested for external specs like css transforms.

  • Remove definition of type and reference CSS3-values.
    That's done (although we still have SVGAngle in types.html).
    The version of CSS3 values referenced is not the latest.

  • Change all coordinate types to in preparation for referencing css3-values..
    There's a problem with this item if we don't actually reference CSS3 values.

  • Add the ‘script’ element to the content model of all elements.
    Without a DTD or schema this statement is meaningless.

  • Changed the initialize, appendItem, replaceItem and insertItemBefore methods on list objects to make a copy of any list item being inserted that is already in another list.
    Yes, in types.html (not sure my JS is up to testing whether this was implemented,
    probably something using ===, but browsers and object identity seem a bit fluid to me)

  • The ‘image’ and ‘script’ elements have gained a crossorigin attribute, for use with the CORS-enabled fetch algorithm.
    Yes to both (not sure how to test this within wpt but confirm the change was made to the spec)

@boggydigital
Copy link
Contributor

Not blocking updated 2.0 CR publication - assigning 2.0 Recommendation milestone to clean this up before 2.0 REC

@svgeesus
Copy link
Contributor

svgeesus commented Aug 5, 2018

Added "length" attribute and indexed property access to all list interfaces.
Seems to be there on at least chrome and firefox. I wrote some tests, which
pass, but only tested read-only access as that's all that the spec requires.
Have not tested for external specs like css transforms.

Were these tests submitted to WPT? Were they reviewed?

Add the ‘script’ element to the content model of all elements.
Without a DTD or schema this statement is meaningless.

The content model is described in the content model part of each element definition in the specification. For example the text element says that script is an allowed child.

Changed the initialize, appendItem, replaceItem and insertItemBefore methods on list objects to make a copy of any list item being inserted that is already in another list.
Yes, in types.html (not sure my JS is up to testing whether this was implemented,
probably something using ===, but browsers and object identity seem a bit fluid to me)

Were these tests submitted to WPT? Were they reviewed?

@liamquin
Copy link
Author

liamquin commented Aug 6, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants