Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-merge test build checks for Pull Requests #541

Open
AmeliaBR opened this issue Sep 4, 2018 · 2 comments
Open

Set up pre-merge test build checks for Pull Requests #541

AmeliaBR opened this issue Sep 4, 2018 · 2 comments
Assignees
Labels

Comments

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Sep 4, 2018

I just created two different PRs fixing build errors introduced by recently merged changes. It would be very useful if we had automated test builds set up as pre-merge checks on GitHub.

If anyone wants to look into doing this, probably through TravisCI, that would be very helpful.

In the meantime, I'm going to suggest that other editors be extra careful about merging an substantive changes without first checking out the PR branch and running a test build locally.

@AmeliaBR AmeliaBR added the Tools label Sep 4, 2018
@AmeliaBR
Copy link
Contributor Author

AmeliaBR commented Sep 5, 2018

In addition:

For changes to the build scripts themselves, the build system for svgwg.org needs to manually restarted (@heycam can do this). This is to prevent rogue scripts from causing mayhem on the server.

So we'd want some sort of extra warning showing up for these PRs. It wouldn't block merging, but it would remind the person doing the merging that an extra step is required.

@svgeesus
Copy link
Contributor

Oops, it seems that we have lost Overview.html and changes.html from the built spec on svgwg.org

(Spotted because the changes link is now broken on our SVG2 CR transition request )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants