Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG Text Layout algorithm adjusts dx and dy wrong #271

Open
karip opened this issue Sep 15, 2016 · 2 comments · May be fixed by #847
Open

SVG Text Layout algorithm adjusts dx and dy wrong #271

karip opened this issue Sep 15, 2016 · 2 comments · May be fixed by #847
Assignees
@svgeesus
Labels
SVG Core Text chapter
Milestone
SVG 2.0 Proposed ...

Comments

@karip
Copy link

karip commented Sep 15, 2016

The step 4.2.2 “Adjust positions: dx, dy” in the text chapter uses wrong variables. It says:

“Let shift.x = shift.x + resolve_x[i] and shift.y = shift.y + resolve_y[i].”

I think it should be

“Let shift.x = shift.x + resolve_dx[i] and shift.y = shift.y + resolve_dy[i].”
@karip karip mentioned this issue Sep 15, 2016
Open
@Tavmjong
Copy link
Contributor

4.2.1 should probably be: Let shift be the cumulative x and y shifts due to ‘dx’ and ‘dy’ attributes, initialized to (0,0).

I will review this further.

@karip
Copy link
Author

karip commented Sep 15, 2016

You are right. Also, the one below it should be:

  1. If resolve_dx[i] is unspecified, set it to 0. If resolve_dy[i] is unspecified, set it to 0.

@boggydigital boggydigital added this to the SVG 2.1 Working Draft milestone Jun 11, 2018
@karip karip mentioned this issue Dec 18, 2018
Open
@svgeesus svgeesus self-assigned this Jan 7, 2019
tkent-google added a commit to tkent-google/svgwg that referenced this issue Apr 27, 2021
@tkent-google
Text Layout Algorithm: Fix incorrect attribute/variable names in "Adj…
80294dd 
…ust positions: dx, dy"

Fixes w3c#271
@tkent-google tkent-google linked a pull request Apr 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svgeesus svgeesus

Labels
SVG Core Text chapter
Projects
None yet
Milestone
SVG 2.0 Proposed Recommendation
6 participants
@boggydigital @dirkschulze @svgeesus @karip @Tavmjong @AmeliaBR