Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should TouchEvent define getModifierState #41

Open
dtapuska opened this issue Oct 29, 2015 · 6 comments
Open

should TouchEvent define getModifierState #41

dtapuska opened this issue Oct 29, 2015 · 6 comments

Comments

@dtapuska
Copy link
Contributor

It seems odd to define the alt, meta, ctrl, shift keys on Touch Events; but nonetheless they are there.

We should define the getModifierState defined in https://w3c.github.io/uievents/#widl-KeyboardEvent-getModifierState if we do #40

@RByers
Copy link
Contributor

RByers commented Oct 29, 2015

They're definitely valuable in touch laptop scenarios (eg. I know some users do ctrl-tap to open links in new tabs, just like ctrl-click). I don't see any reason why TouchEvent should be different from MouseEvent / PointerEvent with respect to modifiers.

Certainly hard to argue this is very important though.

@dtapuska
Copy link
Contributor Author

In blink the implementation is there; the IDL just needs to be modified so the bindings code will call the implementation.

@patrickhlauke
Copy link
Member

still relevant to extend the IDL at this stage, or are we happy to leave as is and focus on pointer events instead?

@RByers
Copy link
Contributor

RByers commented Mar 23, 2017

Meh, seems pretty low priority to me, but also very low cost to just fix to do the right thing consistent with MouseEvent/PointerEvent. If someone (eg. @dtapuska or someone on his team) wants to take a few minutes to submit a PR and expose this in some implementation, then I'd be happy to see it added to the spec. Otherwise this could be closed as too low priority.

@patrickhlauke
Copy link
Member

@dtapuska @RByers are we closing this?

@dtapuska
Copy link
Contributor Author

dtapuska commented Oct 23, 2017

@patrickhlauke patrickhlauke how is this #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants