Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make wider space to the right #24

Closed
r12a opened this issue Nov 3, 2015 · 11 comments
Closed

make wider space to the right #24

r12a opened this issue Nov 3, 2015 · 11 comments
Milestone

Comments

@r12a
Copy link

r12a commented Nov 3, 2015

just raising this to ensure that it wasn't forgotten...

The initial proposal had the main text block centred horizontally in the window.

During TPAC we agreed that there would be a fixed distance margin on the right of the main text block, and that if the window size was increased horizontally the max-width would therefore produce a variable and potentially much larger margin to the right, so as to better accommodate wide tables, diagrams, etc.

@fantasai
Copy link
Contributor

fantasai commented Dec 8, 2015

Fixed. I think it looks a bit awkward visually, but I don't have a better practical answer to the problem of overflow (short of implementing my own layout rules in JS).

@fantasai fantasai closed this as completed Dec 8, 2015
@r12a
Copy link
Author

r12a commented Dec 9, 2015

I think it looks a bit awkward visually,

i think it would look better if you set margin-left: 2em on body (reducing to zero as the screen gets thin). Could you try it?

@r12a r12a reopened this Dec 9, 2015
@plehegar plehegar added this to the 2016 milestone Jan 5, 2016
@fantasai
Copy link
Contributor

Okay, I figured out a way to create centered space in the CSS, so I've mapped that to .overlarge and the figure markup, and recentered the text (which looks a lot better). And since we have JS as an option now with the fixup script, I'm adding .overlarge wrappers automatically for table elements--this is also for handling bug #38. Take a look and let me know if this works for you.

http://fantasai.inkedblade.net/style/design/w3c-restyle/2016/sample#overlarge
http://fantasai.inkedblade.net/style/design/w3c-restyle/2016/sample#property-index

@iherman
Copy link
Member

iherman commented Jan 15, 2016

It does. Thank you.

@r12a
Copy link
Author

r12a commented Jan 15, 2016

I'm seeing this on Firefox 43 on Mac OS X 10.11. (Table and caption right aligned, but caption further to the right.) Any idea why?

screen shot 2016-01-15 at 07 53 09

@r12a r12a reopened this Jan 15, 2016
@fantasai
Copy link
Contributor

No idea why. That looks super weird, alignment-wise. Works fine on Linux. Try shift-reload?
The wrapping is due to an error measuring inline content in Gecko. I'll take a look, but that's a separate issue.

@r12a
Copy link
Author

r12a commented Jan 15, 2016

don't know whether you did something, but it looks ok now. Strange. Thanks.

@r12a r12a closed this as completed Jan 15, 2016
@r12a r12a reopened this Jan 15, 2016
@r12a
Copy link
Author

r12a commented Jan 15, 2016

wait a moment .... ! I guess i'm now seeing the expected effect in wide windows too for the first time. So now the text column is centred except when you have wider elements sticking out on both sides at various places? I think that's horribly ugly. It also makes it hard to spot headings, if you have more than one table or wide item on either side.

Please switch it back. It was looking pretty much ok before. I was suggesting just a smidgen more space to the left, not this. Sorry, i think this is awful. If it's too hard to add the extra 2em, then i think it will be much better left as it was.

@fantasai
Copy link
Contributor

I think this is a point on which reasonable people can agree: imho the left-aligned content block looks bad, and centering is better. :) We can get more opinions on this and see what other people think.

My hope is that the 50em max-width will encourage people to notice when their content is really wide and, aside from tables which can't really be helped, try to make sure it all fits within the column.

@fantasai
Copy link
Contributor

Tab notes that left-aligning looks better when the ToC is popped in, so I'll see about switching it to left-alignment at least in that case.

@fantasai
Copy link
Contributor

Done. Let me know if I should do something similar when the ToC is not there. Atm I think it looks more balanced centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants